Skip to content
This repository has been archived by the owner on Mar 30, 2021. It is now read-only.

Scrolling with touchpad has poor performance #275

Closed
lucascampelo opened this issue Dec 31, 2014 · 10 comments
Closed

Scrolling with touchpad has poor performance #275

lucascampelo opened this issue Dec 31, 2014 · 10 comments
Milestone

Comments

@lucascampelo
Copy link

I have a MacBook Pro and when I try to scroll the page inside Radiant Player with touchpad, the scrollbar is freezing.
I guess the problem is related with "smooth scrolling" of mac os.

I tested scrolling with mouse and works normally, but with touchpad don't works fine.

@bilalq
Copy link

bilalq commented Jan 4, 2015

I just installed this for the first time on Mavericks, and I'm seeing this issue as well.

(Aside from this bug, I must say, this is a pretty well made app).

@akszydelko
Copy link

I often use touchpad and it always is so annoying, it freeze a whole application even when I immediately switch to mouse scroll for the first 2-3s I cannot do anything.
I have MacBook Air with Mavericks.

I have no idea what is the problem here, but first what came to my mind is that scrolling with touchpad generates a hell lot more scroll events fired then mouse scroll.
Take a look at simple js example in Plunker. On touchpad even a small fingers move generates many events. While with mouse scroll the number of event to scroll from top to bottom is constant.

Maybe while scrolling, render is called so many times that it freeze the whole app, but it's just a guess. Hope a helpful one.

@bilalq
Copy link

bilalq commented Jan 5, 2015

That sounds right. Some debouncing logic thrown in should fix it.

@lucascampelo
Copy link
Author

Thanks for the feedback. I'm using Mavericks too.
If what the @akszydelko says its right, can be solved stopping the last scroll event and start again (like some HTML5 animations).

@bilalq
Copy link

bilalq commented Jan 11, 2015

I've noticed that this only happens on my retina MBP. My older, fatter one has no problems.

@Tape
Copy link

Tape commented Jan 14, 2015

This may actually be already fixed just not released yet, I checked out the repo and built with xcode using the instructions in the readme and I have buttery smooth scrolling now. Here's some fairly simple instructions you can follow to do so:

  1. Check out repo.
  2. Open radiant-player-mac.xcworkspace with xcode
  3. Click the play icon on the top left to build
  4. On the left sidebar, ensure the folder icon is clicked and go to the Products folder
  5. Right click on Radiant Player.app and click show in finder
  6. Replace your existing .app file with that one.

@lucascampelo
Copy link
Author

Don't work for me @Tape. Look out:
captura de tela 2015-01-14 as 22 38 17

@Tape
Copy link

Tape commented Jan 15, 2015

That's strange @lucascampelo, unfortunately I'm not intimate with the codebase or really OSX development in general, I managed to get it built no problem. Sorry I can't be of assistance here.

@kbhomes
Copy link
Member

kbhomes commented Feb 16, 2015

@lucascampelo @bilalq: Could you hop on over to #280 and test the pre-release version and see if performance has improved any? Thanks!

@chrismou
Copy link
Member

Hey everyone - I know this is a _really_ old issue, but there's been a ton of fixes/improvements since it was logged.

If possible, could you check latest code and see if you're still seeing the issues you're reporting here? You can either build from master, or for convenience I've tagged a release on my fork of everything up to today: https://github.com/chrismou/radiant-player-mac/releases/tag/v1.5.0-20151213

Thanks!

@jacobwgillespie jacobwgillespie added this to the v2.0.0 milestone Dec 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants