Skip to content
This repository has been archived by the owner on Mar 30, 2021. It is now read-only.

Last.fm integration not working on El Capitan #368

Closed
ameraljovic opened this issue Oct 7, 2015 · 17 comments
Closed

Last.fm integration not working on El Capitan #368

ameraljovic opened this issue Oct 7, 2015 · 17 comments
Assignees
Milestone

Comments

@ameraljovic
Copy link

When trying to authorize my Last.fm account I just get a message: Unable to login to Last.fm.
I use version v1.4.1.

@ameraljovic
Copy link
Author

It seems that this is a issue only on the newest version. With v.1.4.0 it works.

@chrismou
Copy link
Member

chrismou commented Oct 9, 2015

👍 Same

@ameraljovic Which 1.4.0 version are you using? The official binary has the issue with the white box in the bottom left and all the songs skipping.

@ameraljovic
Copy link
Author

@chrismou Yes, the official binary v1.4.0.

@patrickhpan
Copy link

+1 for broken on 1.4.1, El Capitan.

@bruvv
Copy link

bruvv commented Oct 14, 2015

Still broken on 1.4.1 and the 1.4.0 patched

@chrismou
Copy link
Member

Yeah, I can't get it working on any version. 1.4.0 official I get the white box of death, 1.4.0 temp and 1.4.1 official the music plays but it won't scrobble. I've reverted back to the web player for now.

I may have a go at getting it running in Xcode and see if I can see the problem, but Mac development isn't really my speciality so I'm not holding out too much hope. I did wonder if it had something to do with the last.fm redesign/borked API, but it seems strange it would work right up until upgrading to El Capitan.

@chrismou
Copy link
Member

Right, I seem to have fixed it locally. It seems to be something to do with El Capitan forcing connections that are using HTTPS to be TLS 1.2. I'm not sure why that affects scrobbling, but disabling App Transport Security seems to have fixed it for me. Not sure if that's a dirty workaround or not, but I'll put in a pull request to @kbhomes and see what he thinks.

In the meantime, I've released a fixed version here: https://github.com/chrismou/radiant-player-mac/releases/tag/v1.4.1

Would appreciate any testing/feedback on whether it works for you. @ameraljovic @nivong @patrickhpan before I put in a pull request.

@bruvv
Copy link

bruvv commented Oct 20, 2015

Thanks for the fix @chrismou it works!

@viniciushsantana
Copy link

Thanks a lot @chrismou.

@chrismou
Copy link
Member

Cheers guys. I've put in a pull request here: #378

@ameraljovic
Copy link
Author

@chrismou, works like a charm! 🍻

@viniciushsantana
Copy link

Is the hotkeys not working on @chrismou's version? Or just here?

@chrismou
Copy link
Member

No, apparently not. Doesn't seem to be working on @kbhomes's master branch either.

@srvrguy
Copy link

srvrguy commented Oct 23, 2015

The media keys are likely something with the 10.11.1 update, issue #381 is tracking that.

@chrismou
Copy link
Member

Fixed in #378 - should be available in the next release (or by building your own binary from master, if you're feeling impatient) :-)

@chrismou chrismou reopened this Oct 28, 2015
@chrismou
Copy link
Member

Hmm, still not working on master. Looks unrelated to the original issue. Reopening the ticket while I look into wtf has happened

@chrismou
Copy link
Member

Now fixed in #400

@jacobwgillespie jacobwgillespie added this to the v2.0.0 milestone Dec 13, 2015
@chrismou chrismou self-assigned this Dec 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants