Skip to content
This repository has been archived by the owner on Mar 30, 2021. It is now read-only.

Multiple calls to last.fm api at start of every song #425

Closed
chrismou opened this issue Nov 30, 2015 · 2 comments
Closed

Multiple calls to last.fm api at start of every song #425

chrismou opened this issue Nov 30, 2015 · 2 comments

Comments

@chrismou
Copy link
Member

main.js calls GoogleMusicApp.ratingChanged(MusicAPI.Rating.getRating()); within a mutationObserver.

This makes several calls to the last.fm api to love or unlove the track, depending on whether it's been thumbed up or not (if you have the "love a track on last.fm when rated thumbs up" option checked).

The main issue around this has been fixed (#390) but for the sake of efficiency, it would be good to get to the bottom of why it's called so many times and cut it down to only run when the track rating is changed

Follows on from #426

@chrismou
Copy link
Member Author

Note to self: we're not losing loved tracks, but it does seem the unloving/reloving unexpectedly.

http://www.last.fm/user/chrismou/loved

Looking at this, for about 40 minutes on the 23/12 it did the unlove/relove thing so now they're showing at the top of the list.

@jacobwgillespie
Copy link
Member

This has been resolved by the switch to gmusic.js.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants