Skip to content
This repository has been archived by the owner on Mar 30, 2021. It is now read-only.

thumbs not reflected in control bar #429

Closed
zobier opened this issue Dec 2, 2015 · 4 comments
Closed

thumbs not reflected in control bar #429

zobier opened this issue Dec 2, 2015 · 4 comments
Assignees

Comments

@zobier
Copy link

zobier commented Dec 2, 2015

image

I expected the thumb icons in the control bar (on rollover) to reflect my likes.

v 1.5 mac

@jacobwgillespie
Copy link
Member

Yep, I can confirm this one - we need to see if this is an issue with our custom CSS or with Google's webcomponents.js in webkit.

@chrismou
Copy link
Member

chrismou commented Dec 7, 2015

Looks to be the CSS. Thumbed up tracks do have an icon="sj:thumb-up-outline" set on the button, so it'll just be a case of tracking down what's triggering the style change.

I'll look into it

@chrismou chrismou assigned chrismou and unassigned chrismou Dec 7, 2015
@chrismou
Copy link
Member

chrismou commented Dec 7, 2015

OK, I think I spoke too soon. It looks like the icons are SVGs, and when it's thumbed up, it's given a black fill. This works fine on the on the light theme, but looks like nothing's changed on the dark theme.

I'm not sure how to get around this offhand, but I'll have a play.

@chrismou
Copy link
Member

chrismou commented Dec 8, 2015

Think I've got it sorted on dark & light themes. Feel free to check over the PR (#436) when you get a few minutes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants