Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postgresql-client to postgresql-client feature #22

Conversation

duduribeiro
Copy link
Contributor

Currently when you generate an App with postgres and access the devcontainer, it fails to run bin/rails db inside the container terminal because there is no psql installed on it. This commit installs postgresql-client so it can be used inside the devcontainer.

Before installing postgresql-client:

vscode ➜ /workspaces/demo_devcontainer (main) $ bin/rails db
Couldn't find database client: psql. Check your $PATH and try again.

after

vscode ➜ /workspaces/demo_devcontainer (main) $ bin/rails db
Password for user postgres: 
psql (15.6 (Debian 15.6-0+deb12u1), server 15.1 (Debian 15.1-1.pgdg110+1))
Type "help" for help.

demo_devcontainer_development=# 

does it make sense to install postgresql-client on the feature?

Thanks

Currently when you generate an App with postgres and access the
devcontainer, it fails to run `bin/rails db` inside the container
terminal because there is no `psql` installed on it. This commit
installs postgresql-client so it can be used inside the devcontainer.
@rafaelfranca rafaelfranca merged commit 90e0ed8 into rails:main Apr 18, 2024
@duduribeiro duduribeiro deleted the add-postgresql-client-to-postgres-features branch April 18, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants