Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize our URI class rather than leaning on Ruby's URI::Generic as a URL #6

Closed
jeremy opened this issue Aug 16, 2014 · 3 comments
Closed
Milestone

Comments

@jeremy
Copy link
Member

jeremy commented Aug 16, 2014

The initial URI implementation leans on Ruby's URI::Generic and acts as a URL, using the hostname as the app namespace and the first two path segments as model class and id.

Let's formalize this with an actual Global ID URI scheme that takes advantage of Ruby's parser and validation.

@jeremy jeremy added this to the 1.0 milestone Aug 16, 2014
@jeremy
Copy link
Member Author

jeremy commented Aug 17, 2014

Simplified parsing and component validation:

@kaspth
Copy link
Contributor

kaspth commented Sep 25, 2014

Fixed in 608c2b3

@kaspth kaspth closed this as completed Sep 25, 2014
@jeremy
Copy link
Member Author

jeremy commented Sep 25, 2014

🤘 thank you @sebasoga and @kaspth !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants