Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support parrent matching of GlobalID & GlobalID::URI #140

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Support parrent matching of GlobalID & GlobalID::URI #140

merged 1 commit into from
Dec 16, 2022

Conversation

ojab
Copy link
Contributor

@ojab ojab commented Mar 30, 2022

IMHO would be handy to use it in locators, something like

case gid
in app: 'AppOne', model_name: 'ModelOne'
  AppOneModelOneLocator.call(gid.model_id)
in app: 'AppTwo'
  AppTwoLocator.call(gid.model_name, gid.model_id)
else
  # /shrug
end

@ojab ojab force-pushed the pattern_matching branch 3 times, most recently from 1792db2 to 5ba4bea Compare March 30, 2022 19:25
@ojab ojab marked this pull request as ready for review March 30, 2022 19:36
@ojab
Copy link
Contributor Author

ojab commented Oct 26, 2022

ping?

@dhh dhh merged commit fa6058a into rails:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ojab @dhh