Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributes to the search index #370

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

Earlopain
Copy link
Contributor

@Earlopain Earlopain commented Oct 31, 2024

Before After
image image

To make this work correctly, add anchors to the generated html.

RDoc uses the same class for methods and attributes so most of the plumbing was already there.

Closes #369. I oriented myself with #358 which is the PR for adding constants to the search.

To make this work correctly, add anchors to the generated html.

RDoc uses the same class for methods and attributes so most
all of the plumbing was already there.
@zzak zzak merged commit 7de756f into rails:main Nov 1, 2024
4 checks passed
@Earlopain Earlopain deleted the search-attributes branch November 1, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should attr_reader and similar be part of the search index?
2 participants