From 52f2665ed87c9779b16ea0c89d916e0311c66d3a Mon Sep 17 00:00:00 2001 From: Joe Francis Date: Fri, 28 Sep 2018 14:06:39 -0500 Subject: [PATCH 1/2] bump ruby versions for travis, add rails-5.2 --- .travis.yml | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index e170e456..b454ba54 100644 --- a/.travis.yml +++ b/.travis.yml @@ -5,14 +5,16 @@ rvm: - 1.9.3 # when removed, get rid of the before_script hack and also the one in application_generator.rb - 2.0.0 - 2.1.10 - - 2.2.7 - - 2.3.4 - - 2.4.1 + - 2.2.10 + - 2.3.7 + - 2.4.4 + - 2.5.1 - ruby-head env: - RAILS_VERSION="~> 4.2.0" - RAILS_VERSION="~> 5.0.0" - RAILS_VERSION="~> 5.1.0" + - RAILS_VERSION="~> 5.2.0" matrix: exclude: # Rails 5 is incompatible with Ruby < 2.2.2 - rvm: 1.9.3 @@ -27,6 +29,12 @@ matrix: env: RAILS_VERSION="~> 5.1.0" - rvm: 2.1.10 env: RAILS_VERSION="~> 5.1.0" + - rvm: 1.9.3 + env: RAILS_VERSION="~> 5.2.0" + - rvm: 2.0.0 + env: RAILS_VERSION="~> 5.2.0" + - rvm: 2.1.10 + env: RAILS_VERSION="~> 5.2.0" allow_failures: - rvm: ruby-head fast_finish: true From 5536a595816da76b7ca2fd1836ad8c3727298a49 Mon Sep 17 00:00:00 2001 From: Joe Francis Date: Fri, 28 Sep 2018 15:09:32 -0500 Subject: [PATCH 2/2] skip system tests and listen for acceptance tests The listen gem was causing intermittent travis errors. System tests were causing a dependency on capybara, which caused build failures with ruby versions < 2.3 --- lib/spring/test/application_generator.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/spring/test/application_generator.rb b/lib/spring/test/application_generator.rb index 6565a215..67310c5c 100644 --- a/lib/spring/test/application_generator.rb +++ b/lib/spring/test/application_generator.rb @@ -48,7 +48,7 @@ def generate_files @version = RailsVersion.new(`ruby -e 'puts Gem::Specification.find_by_name("rails", "#{version_constraint}").version'`.chomp) - skips = %w(--skip-bundle --skip-javascript --skip-sprockets --skip-spring) + skips = %w(--skip-bundle --skip-javascript --skip-sprockets --skip-spring --skip-listen --skip-system-test) system("rails _#{version}_ new #{application.root} #{skips.join(' ')}") raise "application generation failed" unless application.exists?