[#close 242] Threadsafe cache loader #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/threadsafe-cache-path-expand
branch
from
5606651
to
138bcd9
Compare
I'm honestly still not sure how to trigger this error, however the root cause looks like two threads trying to mutate the same values from the cache. rails/rails#24627 The issue should be mitigated by copying the set to a local copy via `dup` and then mutating that. To accomplish this, two helper methods have been added.
schneems
force-pushed
the
schneems/threadsafe-cache-path-expand
branch
from
138bcd9
to
36741c6
Compare
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm honestly still not sure how to trigger this error, however the root cause looks like two threads trying to mutate the same values from the cache.
rails/rails#24627
The issue should be mitigated by copying the set to a local copy via
dupand then mutating that.To accomplish this, two helper methods have been added.