Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rake templates:test #318

Merged
merged 14 commits into from
Jun 11, 2022
Merged

Conversation

mishina2228
Copy link

@mishina2228 mishina2228 commented Jun 9, 2022

rake templates:test was left to fail for a long time.
This PR will fix it (with a slightly larger number of file changes).
Here are the details:

I ran the test locally and confirmed that it succeeded.

$ bundle exec rake templates:test


..............................
30 passing (679ms)

@gsamokovarov
Copy link
Collaborator

Thanks for all the little details you fixed along the way! 🙇‍♂️

@gsamokovarov gsamokovarov merged commit 83b282e into rails:master Jun 11, 2022
@mishina2228 mishina2228 deleted the fix-for-templates-test branch June 12, 2022 05:54
JoeDupuis added a commit to JoeDupuis/web-console that referenced this pull request Aug 22, 2023
[rails#318] introduced a [regression](rails#331) for apps running Rack 2.
Rack 3 follows the http 2 spec and requires lowercase headers.
By using the Rack header constants we get the correct capitalization
regardless of which rack version is loaded.
JoeDupuis added a commit to JoeDupuis/web-console that referenced this pull request Aug 22, 2023
[rails#318] introduced a [regression](rails#331) for apps running Rack 2.
Rack 3 follows the http 2 spec and requires lowercase headers.
By using the Rack header constants we get the correct capitalization
regardless of which rack version is loaded.
JoeDupuis added a commit to JoeDupuis/web-console that referenced this pull request Aug 22, 2023
[rails#318] introduced a [regression](rails#331) for apps running Rack 2.
Rack 3 follows the http 2 spec and requires lowercase headers.
By using the Rack header constants we get the correct capitalization
regardless of which rack version is loaded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants