forked from gsamokovarov/web-console
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rake templates:test
#318
Merged
gsamokovarov
merged 14 commits into
rails:master
from
mishina2228:fix-for-templates-test
Jun 11, 2022
Merged
Fix rake templates:test
#318
gsamokovarov
merged 14 commits into
rails:master
from
mishina2228:fix-for-templates-test
Jun 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ActionView is in use without Rails at `rake templates:test`
This fix the following error: ``` ActionView::Template::Error: undefined method `to_sym' for nil:NilClass @symbol = symbol.to_sym ^^^^^^^ ```
This is workaround for direct-adv-interfaces/mocha-headless-chrome#52
The latest rack 3.0 (unreleased) does not accept uppercase headers. See rack/rack#1592 for more details. refs: - rack/rack#1812 - rails/sprockets#744
Similar change as rails#290
`test/templates/spec` is removed at rails#211
We need `done` here
Thanks for all the little details you fixed along the way! 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rake templates:test
was left to fail for a long time.This PR will fix it (with a slightly larger number of file changes).
Here are the details:
.
in the nameRails.logger
is definedrake templates:test
require "action_dispatch"
to useMime::Type
See Make response headers a hash and enforce lower-case keys. rack/rack#1592 for more details.
test/
, also to files underlib/
.FakeMiddleware
I ran the test locally and confirmed that it succeeded.