rejectVersionFunction gets the semver string as its first argument, not the name of the package

[MissingNoIOI]

• I have searched for similar issues

---

Steps to Reproduce

.ncurc.js:

module.exports = {
  rejectVersion: (name, semver) => {
    console.log(name)
    if (name == 'chai' && parseInt(semver[0]?.major) >= 5) {
      return true
    }
    if (name == 'sinon-chai' && parseInt(semver[0]?.major) >= 4) {
      return true
    }
    if (name == 'chai-exclude' && parseInt(semver[0]?.major) >= 3) {
      return true
    }
    if (name == 'sort-keys' && parseInt(semver[0]?.major) >= 5) {
      return true
    }
    if (name == '@typescript-eslint/parser' && parseInt(semver[0]?.major) >= 7) {
      return true
    }
    if (name == '@typescript-eslint/eslint-plugin' && parseInt(semver[0]?.major) >= 7) {
      return true
    }
    return false
  }
}

Steps:
Execute ncu with this configuration file

Current Behavior

The first argument that gets passed in is the string of the version, like "^4.3.16"

Expected Behavior

The first argument that gets passed in should be the name of the package, as described in the documentation. This way the rejectVersion function is not really useful

[raineorshine]

Hi, thanks for reporting.

Yes, that's definitely not right. I'll work on cleaning that up. Any change in behavior will have to wait for a major version update, but in the mean time can you try switching to reject or filter instead of rejectVersion? I believe they pass (name, semver) as expected.

[MissingNoIOI]

Yeah, with reject it inputs the name correctly, but the semver is now the current version, instead of the one to be upgraded to, so I cant filter the version either.

[raineorshine]

filter and reject run before the latest versions are fetched, so you will not have access to the upgraded versions there. They are preferred when only filtering based on name or current version because they reduce the number of HTTP requests.

filterResults runs after the latest versions are fetched, allowing you to filter on the upgraded version.

[rubiesonthesky]

I have same problem with filterVersion, it's returning version instead of name so I can't filter out broken package version. Are there any way to some how reject or filter out this one version of certain package?

  filterVersion: (name, semver) => {
    if (name === 'codemirror' && semver[0]?.semver === '6.65.7') {
      return false
    }
    return true
  }

[rubiesonthesky]

^ I was able to achieve what I wanted with this code:

  filterResults: (packageName, {upgradedVersion}) => {
    console.log(packageName, upgradedVersion)
    if (packageName === 'codemirror' && upgradedVersion === '6.65.7') {
      return false
    }
    return true
  }

But the Readme is incorrect for filterResults. It says that the arguments are like packageName, { current, currentSemver, upgraded, upgradedSemver } when in practise the second object contains currentVersion, currentVersionSemver, upgradedVersion and upgradeVersionSemver.

[raineorshine]

Thanks, I will update the README!