Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"name-filter" will lead to confusion #257

Open
xp44mm opened this issue Sep 2, 2021 · 5 comments
Open

"name-filter" will lead to confusion #257

xp44mm opened this issue Sep 2, 2021 · 5 comments
Assignees

Comments

@xp44mm
Copy link

xp44mm commented Sep 2, 2021

This is a issue about the help documentation page.

In the browser, the text input box prompts for a drop-down list, which is a list of user registration names.

<input class="form-control" tabindex="1" id="name-filter" ... >

It is recommended that you rename the name "name-filter" of the id to avoid prompts for browser errors.

@CrossEye
Copy link
Member

CrossEye commented Sep 3, 2021

I'm sorry, I don't follow this.

What error are we trying to avoid?

@xp44mm
Copy link
Author

xp44mm commented Sep 5, 2021

I'm not quite sure if modifying the id doesn't include "name" to fix this conflict.

@CrossEye
Copy link
Member

CrossEye commented Sep 5, 2021

I'm sorry. I still don't understand what issue you're having. Do you have screenshots or console sessions or something that can help explain it? What browser are you using? When do you see the error?

@xp44mm
Copy link
Author

xp44mm commented Sep 5, 2021

x

@CrossEye
Copy link
Member

CrossEye commented Sep 5, 2021

Hmm, I've never seen that. But I certainly have no issue renaming the field. Perhaps something like function-name-filter.

If you feel like raising a PR for this, it would be in the https://github.com/ramda/ramda.github.io repository. If not, I'll try to change it next time I'm in there.

@customcommander customcommander transferred this issue from ramda/ramda Dec 17, 2021
@CrossEye CrossEye self-assigned this Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants