Use verbose error message when redeclaring an imported function (#54) #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi thanks and sorry for the delay. i will try to get to this this weekend. a bit swamped atm, thanks for your understanding |
|
No sorrows Michael, and thanks for the heads up. Let me know if you want a call if it'd make it any easier. |
|
if you don't hear anything by sunday pinging would probably be a good idea |
|
gonna try and get a look at this tonight. thanks for your patience |
|
ok finally getting to this! this looks like a great change, thanks. I am also getting those test errors. I am gonna spend a (very) little amount of time trying to get those fixed up, then will be happy to merge this. Thanks for the PR and sorry for the delay |
|
ok will leave the tests aside for now, not sure what borked those, but clearly not this PR's responsibility |
|
🐄 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user declares a variable that conflicts with one of Ramda's imported functions, the error message will now say:
This will close issue #54.
I think the changes are good to go but two tests are failing locally on
masterand this branch.Not sure if you or TravisCI will have the same issues: