Add CodeMirror commenting addon and Sublime keymap #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry this was dropped. I don't think there is anyone really looking at this repo any more. |
|
@CrossEye No worries at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** DO NOT MERGE YET **
@CrossEye
This PR is in reference to issue
This is to add the functionality to comment code (line/block) within the REPL.
I imported the comment addon from CodeMirror along with the Sublime keymap that will enable commenting of code with
CMD/CTRL + /.I have been unable to get the functionality to work, however. I used the graphql/graphiql REPL as a guide as it uses CodeMirror in a similar style and has the commenting functionality.
My only guess after hitting a wall with it is that what the Ramda is doing to process the input is ignoring/blocking the commenting functionality.
I hope someone is able to chip in and help get this feature added. I'm happy to help in any way if there is something that I am obviously missing.
Thanks!