TS: Incorrect signature of R.values

[lisumio]

Assumption: Calling values method with null works by design and not by mistake (returns []).

R.values expects input obj to be a T generic that extends object , but this produces following error when passing nullable type:

Type 'null' is not assignable to type 'object'

PS. After checking ramda/ramda#3264 and seeing that #118 is left open I've decided to post this issue here rather than in DefinitelyTyped - hope it's alright.

[kpkonghk01]

Is it solved?

When I pass null into function values<T extends object>(obj: T): ValueOfUnion<T>[];, ValueOfUnion<null> becomes never. So values(null) returns type never[], which should be correct.

ref:
https://github.com/ramda/types/blob/develop/types/values.d.ts#L3C51-L3C63
https://github.com/ramda/types/blob/develop/types/util/tools.d.ts#L419

[Harris-Miller]

R.values() rejects null same as Object.values. See here for example: https://tsplay.dev/WY5AxW

I believe the current implementation is correct. Closing