New: basic compare functions lt
, lte
, gt
, gte
#11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR improves the typings for
lt
,lte
,gt
, andgte
to include allOrd
typesIt also corrects the curry typing and removes the incorrect operand switching
Please note the addition and use of
WidenLiterals
. This is important only when you haveThe overloads orders are also updated so it's least to most arity. This is important because of how typescript used the last defined overload when accepting a function as an argument. When you do
flip(lt)
for example, in the previous orderflip
would have received the type(a: Ord) => (b: ord) = boolean
. That is incorrect. The new ordering makes it so it receives(a: Ord, b: Ord) => boolean
To support that change an additional overload to the return type of
flip
had to be added for currying.