Fixing sleep interval that compounds #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorenzoLeonardo
force-pushed
the
MaxBackOffInterval
branch
from
e5dc06d
to
173e13a
Compare
LorenzoLeonardo
force-pushed
the
MaxBackOffInterval
branch
from
173e13a
to
1d2ba24
Compare
It was observe that during polling of token, if an error keeps returning from the http_client, the sleep interval compounds by 2. This scenario can be reproduced if ethernet cable is unplugged for a long time not more than the expiry time. To reproduced, set up a custom curl http_client with connect_timeout() and timeout() from Easy2 curl-rust crate. Thus, a max back off interval is introduce to put a limit to the compounding of time interval.
LorenzoLeonardo
force-pushed
the
MaxBackOffInterval
branch
from
1d2ba24
to
d9bd552
Compare
|
@ramosbugs solution for issue #214. Please check |
|
thanks! |
|
Hello David
Do you have plans to version up the crate? I will use it with this fix.
Thanks a lot.
Best Regards
Lorenzo
…On Wed, May 17, 2023 at 7:15 AM David Ramos ***@***.***> wrote:
thanks!
—
Reply to this email directly, view it on GitHub
<#216 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXKWVQLVFCWADFCBWU3IDTLXGQDCXANCNFSM6AAAAAAYDQZ4AQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
4.4.0 is now published |
|
Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was observe that during polling of token, if an error keeps returning from the http_client, the sleep interval compounds by 2. This scenario can be reproduced if ethernet cable is unplugged for a long time not more than the expiry time.
To reproduced, set up a custom curl http_client with connect_timeout() and timeout() from Easy2 curl-rust crate.
Thus, a max back off interval is introduce to up a limit to the compounding of time interval.