Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs may have been found #5

Open
m3r3lin opened this issue Jun 14, 2023 · 1 comment
Open

Bugs may have been found #5

m3r3lin opened this issue Jun 14, 2023 · 1 comment

Comments

@m3r3lin
Copy link

m3r3lin commented Jun 14, 2023

please check this line :

https://github.com/ramwin/viewflow-rest/blob/74a1f86f530329fc452dae356a95746e096197dc/viewflow_rest/activations.py#LL263C13-L263C22

It should change as follows:

task = get_or_create_task(
            flow_class.task_class,
            process=prev_activation.process,
            flow_task=flow_task.name,
            previous=prev_activation.task
        )

or this lines:

https://github.com/ramwin/viewflow-rest/blob/74a1f86f530329fc452dae356a95746e096197dc/viewflow_rest/activations.py#LL379C1-L383C18

maybe change as follows:

self.flow_class.task_class._default_manager.filter(
    process=self.process,
    status=STATUS_CHOICE.DONE,
    flow_task=incoming_edge.src.name,
).latest('id')

Because in the following process, if the condition of the last step is not true and it returns to the step before joining, it will give an error that there is more than one task and it is not possible with the get() operation.

image

@ramwin
Copy link
Owner

ramwin commented Jun 19, 2023

Thanks, I will try to fix it later. MR is also welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants