Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add host dependency on 'setuptools', ignore renovate Python updates #113

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

jameslamb
Copy link
Member

The renovate bot just opened #112, trying to upgrade the CI image used in this repo for wheel builds / tests from python:3.9 to python:3.13.

We don't want those types of updates... it's an intentional choice that rapids-dependency-file-generator wheels are built and tested on the oldest Python version this tool supports.

This PR attempts to tell renovate not to make such recommendations in the future. I saw "attempts" because I have no idea how to test this.

references suggesting this ignoreDeps field is the right way to do this:

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Oct 9, 2024
@jameslamb jameslamb changed the title ignore renovate Python updates chore: ignore renovate Python updates Oct 9, 2024
@jameslamb jameslamb changed the title chore: ignore renovate Python updates fix: add host dependency on 'setuptools', ignore renovate Python updates Oct 9, 2024
@jameslamb
Copy link
Member Author

conda builds here failed like this:

ModuleNotFoundError: No module named 'setuptools'

(build link)

Makes sense... this project uses setuptools as its build backend but doesn't declare a host dependency on it in its conda recipe. We must have just been getting that transitively before.

[build-system]
requires = ["setuptools"]
build-backend = "setuptools.build_meta"

I just pushed a commit here adding a host dependency on setuptools, to fix that. I also changed the title to fix: so this will result in publishing a new patch version (1.15.1)... I think that's warranted, given that this now potentially changes the build environment and therefore the conda package contents.

@jameslamb jameslamb merged commit 5e43e0c into rapidsai:main Oct 9, 2024
5 checks passed
GPUtester pushed a commit that referenced this pull request Oct 9, 2024
## [1.15.1](v1.15.0...v1.15.1) (2024-10-09)

### Bug Fixes

* add host dependency on 'setuptools', ignore renovate Python updates ([#113](#113)) ([5e43e0c](5e43e0c))
@GPUtester
Copy link

🎉 This PR is included in version 1.15.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jameslamb jameslamb deleted the ignore-renovate-python branch October 9, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants