feat: Add matrix support to pyproject.toml #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleFromNVIDIA
changed the title
trxcllnt
approved these changes
Mar 19, 2024
vyasr
requested changes
Mar 20, 2024
There was a problem hiding this comment.
I think we need to add some testing/error checking for some additional cases.
- What happens if you have a dependencies.yaml where a matrix is specified in the
filessection for a file where the output is pyproject? Right now I think it'll just overwrite in sequence and you'll end up with the last matrix entry, but I think that case should probably still error. Perhaps more precisely, we should only allow a single matrix entry. If the user wants to use a matrixed dependency list with a pyproject file key, that is OK but they either have to use no matrix and fall back to defaults, or they need to specify a single matrix element to build with - We should add a test for matrix fallback behavior with pyproject outputs. I think everything there should work fine since the logic for selecting dependencies from dependency lists is handled independently of any file type-specific code path, but we should verify that.
src/rapids_dependency_file_generator/rapids_dependency_file_generator.py
Show resolved
Hide resolved
src/rapids_dependency_file_generator/rapids_dependency_file_generator.py
Outdated
Show resolved
Hide resolved
Done |
vyasr
approved these changes
Mar 21, 2024
GPUtester
pushed a commit
that referenced
this pull request
Mar 21, 2024
# [1.11.0](v1.10.0...v1.11.0) (2024-03-21) ### Features * Add matrix support to pyproject.toml ([#70](#70)) ([0ebbd69](0ebbd69))
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
difyrrwrzd
added a commit
to difyrrwrzd/dependency-file-generator
that referenced
this pull request
Aug 10, 2024
# [1.11.0](rapidsai/dependency-file-generator@v1.10.0...v1.11.0) (2024-03-21) ### Features * Add matrix support to pyproject.toml ([#70](rapidsai/dependency-file-generator#70)) ([b24d352](rapidsai/dependency-file-generator@b24d352))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: @trxcllnt