fix: raise informative error if 'extras' key is missing for pyproject files #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #87.
mypy
caught some code that's treatingFile.extras
as if it's unconditionally notNone
, when it actually can beNone
.This fixes that by correcting some types hints and explicitly raising an error if a
None
makes it to the part ofmake_dependency_file()
where thatextras
field is nedeed.Prior to this change, given a
dependencies.yaml
like this:rapids-dependency-file-generator
would raise an error like this:As of this change, the error is more informative and requires less knowledge of the
rapids-dependency-file-generator
internals: