-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: raise an informative error if pip map is passed for requirements file #97
Conversation
- pip: | ||
- pandas<1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before this PR, doing something like this would result in an error that'd require understanding the internals of rapids-dependency-file-generator
.
Traceback (most recent call last):
...
TypeError: sequence item 1: expected str instance, dict found
As of this PR, I think the error message rapids-dependency-file-generator
will point people pretty directly to the issue.
Traceback (most recent call last):
...
ValueError: Map inputs like {'pip': ['pandas<1.0']} are not allowed for the 'requirements' file type.
The extra couple commits I just pushed here were attempts to diagnose this:
(build link). I had been using the following in default_language_version:
python: python3.9 Changing that to this pattern used across most of the RAPIDS repos resolved it: default_language_version:
python: python3 I'm going to merge this as I don't think that's a controversial choice and it'd be easy to revert. Wanted to just explain so you know I'm not trying to sneak in some other changes on a stale approval 😅 |
## [1.13.11](v1.13.10...v1.13.11) (2024-05-16) ### Bug Fixes * raise an informative error if pip map is passed for requirements file ([#97](#97)) ([46f142c](46f142c))
🎉 This PR is included in version 1.13.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [1.13.11](rapidsai/dependency-file-generator@v1.13.10...v1.13.11) (2024-05-16) ### Bug Fixes * raise an informative error if pip map is passed for requirements file ([#97](rapidsai/dependency-file-generator#97)) ([e640405](rapidsai/dependency-file-generator@e640405))
Fixes #87.
mypy
(without--strict
)mypy
pre-commit autoupdate
Notes for Reviewers
This won't pass CI until #94 is merged.