Dma heap changes. #574
Merged
Dma heap changes. #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidplowman
reviewed
Oct 4, 2023
davidplowman
reviewed
Oct 4, 2023
davidplowman
reviewed
Oct 4, 2023
Add a dma heap allocator class that will be used to allocate framebuffers instead of using V4L2 to allocate them. Signed-off-by: Naushir Patuck <[email protected]>
Switch to using the dma heap allocator for all libcamera framebuffers that will be used in requests. Signed-off-by: Naushir Patuck <[email protected]>
With the dma heap allocator, we need to carefully handle CPU coherency with the framebuffers. To do this, add two helper classes, BufferReadSync and BufferWriteSync that need to be constructed when accessing a buffer for read or write respectively. This replaces the existing LibcameraApp::Mmap() function. Note that for simplicity, when a request is complete, we mark the buffer read coherent automatically until the buffer is re-sent back in a future request. This makes the function of BufferReadSync mostly a no-op. Signed-off-by: Naushir Patuck <[email protected]>
|
My other questions notwithstanding, I'm happy merge whenever you want. Perhaps we should also patch up the style checker complaints? Otherwise they might haunt us forever...! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.