Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Better handling of missing camera dev nodes #579

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

naushir
Copy link
Collaborator

@naushir naushir commented Oct 9, 2023

Preserve the historical behaviour where if a camera dev node is missing, we report it as "no camera available" instead of an unknown platform.

@naushir
Copy link
Collaborator Author

naushir commented Oct 9, 2023

@davidplowman maybe better?

@naushir
Copy link
Collaborator Author

naushir commented Oct 9, 2023

Hmmm, now Platform::UNKNOWN can never be signalled!

Now addressed.

Preserve the historical behaviour where if a camera dev node is missing,
we report it as "no camera available" instead of an unknown platform.

Signed-off-by: Naushir Patuck <[email protected]>
@davidplowman davidplowman merged commit 9ca255a into main Oct 9, 2023
5 of 6 checks passed
@naushir naushir deleted the dev_node branch October 9, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants