-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artist country not always returned #8
Comments
I'm using this script I turned on both "process track artists" and "include area details" options. There were instances where the "xx" issue occurred when loading multiple releases, but the issue was resolved when refreshing the album corresponding to "xx" in Picard. However, we found a problem where only "xx" is returned when the artist's country is "Ireland". I'm glad I found the plugin I really needed and it's really useful. |
@kthugs, can you please provide an example of a release that isn't working (MBID or link to the release) so I can test it here? Also I did find a bug that caused that for cases where the country was being returned from the MusicBrainz API as an ISO-3166-2 code rather than an ISO-3166-1 code. I wasn't aware the API would do that. I've updated the plugin to accept either version, so if you're not using version 0.4, I suggest that you update your version of the plugin and see if that helps. I'm still trying to solve the issue with having to reload a release to get the country code to work reliably. |
@kthugs, thanks for the examples. These helped point to an odd case of possibly mis-linked areas in the MB database. I've updated the plugin to accommodate this situation, and it now properly shows Ireland as the country for the examples you provided. You can download the updated plugin from my repo and install it manually using the instructions for Installing Third-Party Plugins. If you try this, please let me know if the plugin works for you. Note that I'm still trying to find a fix for sometimes having to reload a release to get the country code properly assigned, so I'm not closing off this issue. |
@rdswift, Works great!! |
I think that I have corrected the problem with some artist countries not being returned unless you reload the release. Can you please download the updated plugin from my repo and install it manually using the instructions for Installing Third-Party Plugins. Please test it out and let me know if this resolves the issue or if you're still having problems. Once we're sure that it seems to be corrected, I'll package it up and submit the update to the "official" Picard plugins for general release. Thanks. Also note that the option settings for the plugin have changed slightly to provide more granularity regarding which types to omit from the location shown in the tags. |
@rdswift
When loading several albums with a small number of tracks, such as EPs or singles, only 1 album out of 12 displayed "xx". Albums that were multi-disc and had a lot of tracks were terribly slow to load, so it felt like the "xx" value occurred more often, but it didn't make much of a difference. !!I just discovered something but!! |
@kthugs, thanks for checking. I'll give it another look, but I haven't been able to get it to fail here with the latest changes. Hopefully I can reproduce the problem using the types of releases you've mentioned.
I'm assuming you mean the rapper R-Swift since I couldn't find an artist by the name of "rdswift". In any case, that behavior by the plugin is expected (except the part of not properly indicating the country on the first load 😉 ) because it retains all area and artist information that it looks up in a cache which only gets cleared when Picard is shut down. This saves time loading other releases (or refreshing already loaded releases) by not re-requesting information (especialy areas) that it has already looked up. The issue is that it is finalizing the artist information before all of the related area lookups are complete, and (obviously) I haven't yet found a way to reliably get around that. |
@rdswift Now, let’s change the order of Picard’s loading list. This time, I changed the folder name so that the 12th track album is listed first. These are five albums, each from a different artist. Tried it again with The Verve albums. Additionally, we tried again with multiple albums from a single artist. I'm confused 😱 |
It would be nice if everything worked as intended, but it's not difficult to press Ctrl + R to refresh once. |
I’m not sure if the new version succeeds in pulling in the artist country much more often, but as @kthugs commented, it’s not that much work to hit Ctrl-R. Thanks! |
See the initial discussion on the Community Forum, where @mfmeulenbelt was encountering problems with the artist country information not always being returned from the Additional Artists Details plugin.
The text was updated successfully, but these errors were encountered: