feat: Hooks and API simplifications #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taion
reviewed
Mar 15, 2019
src/DropdownMenu.js
Outdated
| this.context.show == null ? this.props.show : this.context.show; | ||
|
|
||
| const alignEnd = | ||
| this.context.alignEnd == null |
There was a problem hiding this comment.
shouldn't props win over context in general?
There was a problem hiding this comment.
probably...this was the way it was i think
| @@ -21,22 +33,15 @@ const propTypes = { | |||
| */ | |||
| children: PropTypes.func.isRequired, | |||
| }; | |||
|
|
|||
| function DropdownToggle({ children }) { | |||
There was a problem hiding this comment.
is this essentially soft-deprecated in favor of the hook now?
There was a problem hiding this comment.
maybe, i'm not convinced the pure hook api here is the best option, at least not until there is a proper popper.js hooks api
taion
approved these changes
Apr 2, 2019
jquense
changed the title
|
gonna clean up the lint in a min |
nihgwu
reviewed
Jun 3, 2019
| "warning": "^4.0.2" | ||
| "react-popper": "^1.3.3", | ||
| "uncontrollable": "^6.1.0", | ||
| "warning": "^4.0.3" | ||
| }, | ||
| "peerDependencies": { | ||
| "react": ">=16.3.0", |
There was a problem hiding this comment.
we should bump up the peer dependencies as we are using hooks now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.