You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I haven't created an issue for it, but seems to be the same issue found here: #2447
Error it fixes is the following, which for me personally occurred when re-rendering with the map with a partially different set of Markers.
For performance reasons in my project on render only markers that are within the specified region are returned with render, with the map re-rendering markers using onRegionChangeComplete. With small changes it is generally fine however I found when animating a region change where a lot of markers change this crash would occur.
This simple change in the java code fixed the issue for me.
(please link the issue here)
How did you test this PR?
I only have this issue on Android, and I could consistently replicate the crash on a suite of android test devices. After the fix it was easy to confirm that it fixed the issue for me. Also the code snippet is pretty harmless and contained, checks for null and should not introduce any crashes.
I haven't created an issue for it, but seems to be the same issue found here: #2447
Error it fixes is the following, which for me personally occurred when re-rendering with the map with a partially different set of Markers.
For performance reasons in my project on render only markers that are within the specified region are returned with render, with the map re-rendering markers using onRegionChangeComplete. With small changes it is generally fine however I found when animating a region change where a lot of markers change this crash would occur.
This simple change in the java code fixed the issue for me.
(please link the issue here)
How did you test this PR?
I only have this issue on Android, and I could consistently replicate the crash on a suite of android test devices. After the fix it was easy to confirm that it fixed the issue for me. Also the code snippet is pretty harmless and contained, checks for null and should not introduce any crashes.
I am still facing same issue after this fix too.Any other solution for this??
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No.
What issue is this PR fixing?
I haven't created an issue for it, but seems to be the same issue found here:
#2447
Error it fixes is the following, which for me personally occurred when re-rendering with the map with a partially different set of Markers.
For performance reasons in my project on render only markers that are within the specified region are returned with render, with the map re-rendering markers using
onRegionChangeComplete. With small changes it is generally fine however I found when animating a region change where a lot of markers change this crash would occur.This simple change in the java code fixed the issue for me.
(please link the issue here)
How did you test this PR?
I only have this issue on Android, and I could consistently replicate the crash on a suite of android test devices. After the fix it was easy to confirm that it fixed the issue for me. Also the code snippet is pretty harmless and contained, checks for null and should not introduce any crashes.