Support for lineCap and lineDash pattern #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kruyvanna Thanks for the PR. Any chance you can add this information to the docs? |
|
@christopherdro I updated the docs. |
| @@ -97,6 +98,12 @@ public void setlineCap(AirMapPolyline view, String lineCap) { | |||
| view.setLineCap(cap); | |||
| } | |||
|
|
|||
| @ReactProp(name = "lineDashPattern") | |||
| public void setLineDashPattern(AirMapPolyline view, ReadableArray patternValues) { | |||
| Log.i("VANNA", "setLineDash " + patternValues); | |||
There was a problem hiding this comment.
@kruyvanna Could you remove this log here?
|
@kruyvanna Thank you. Just left one more comment to remove a debug log left behind. |
|
@christopherdro done. |
salah-ghanim
reviewed
Mar 6, 2019
| @@ -4,6 +4,7 @@ | |||
| import android.graphics.Color; | |||
| import android.os.Build; | |||
| import android.util.DisplayMetrics; | |||
| import android.util.Log; | |||
There was a problem hiding this comment.
@kruyvanna please remove this import
once done I'm more than happy to test and merge
|
@salah-ghanim done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
Yes. But this one does one more thing which is LineDashPattern
(please answer here)
What issue is this PR fixing?
No issue reported yet.
(please link the issue here)
How did you test this PR?
Tested.
You're welcome