Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo #2685

Merged
merged 1 commit into from
Feb 3, 2019
Merged

typo #2685

merged 1 commit into from
Feb 3, 2019

Conversation

RWOverdijk
Copy link
Contributor

TLDR LOL

@markmssd
Copy link

markmssd commented Feb 1, 2019

Looks like a breaking change, did you test it properly? Unit tests? Functional tests? Regression tests? Performance tests?

!!!

@RWOverdijk
Copy link
Contributor Author

@markmssd I did something better. I printed it out and did a taste test. I unomnommented it.

@christopherdro christopherdro merged commit 6b2ddbf into react-native-maps:master Feb 3, 2019
@RWOverdijk RWOverdijk deleted the patch-1 branch February 4, 2019 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherdro christopherdro christopherdro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RWOverdijk @markmssd @christopherdro