Fix iOS video not displaying after switching source #1395
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1394
When switching videos on iOS the video loads but does not display. I tracked this down to:
https://github.com/react-native-community/react-native-video/pull/1310/files#diff-42e8804735be64e84d6dd1fb103210a1R861
where applying modifiers while setting the source causes us to lose the player layer and not display the new video.
@ashnfb Please do your best to do extensive testing around switching sources & different video types before submitting PRs. We need to do everything we can to avoid regressions creeping into releases as this breaks apps for numerous developers. It ended up taking about an hour and a half to track this down which would be best spent on reviewing PRs & fixing bugs.
@n1ru4l heads up on regression