Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Google Maps SDK Renderer #3991

Closed
Borduhh opened this issue Oct 27, 2021 · 11 comments
Closed

New Google Maps SDK Renderer #3991

Borduhh opened this issue Oct 27, 2021 · 11 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@Borduhh
Copy link
Contributor

Borduhh commented Oct 27, 2021

Feature request

Why it is needed

All devices on Android 5.0 (Lollipop) or later with 2 GB or more of data storage will use the new renderer. All other devices will continue to use the legacy renderer until further notice. SDK Progressive Rollout beginning March 2022.

Possible implementation

Upgrade Maps SDK to the new renderer (https://developers.google.com/maps/documentation/android-sdk/renderer)

@amr-beshr
Copy link

@Borduhh +1 👍

@dishantwalia
Copy link

dishantwalia commented Oct 28, 2021

Need to update Map Renderer before March 2022.
Steps to follow

@christopherdro christopherdro added the help wanted Extra attention is needed label Oct 28, 2021
@siddharth-kt
Copy link

+1 👍

1 similar comment
@anirudhabhurke
Copy link

+1 👍

@salah-ghanim salah-ghanim self-assigned this Nov 4, 2021
@salah-ghanim
Copy link
Collaborator

salah-ghanim commented Nov 4, 2021

I will take this issue, it looks simple to implement and for now I would just expose a prop to choose the renderer type.

the only issue I see is that the SDK demo shows initialization on application create, so it might be too late if we do it via prop (when view is loaded).

ref: https://developers.google.com/maps/documentation/android-sdk/renderer

@pke
Copy link

pke commented Nov 19, 2021

Is there any action required at all here? This repo still uses Maps SDK 5.1 so its not affected by Google's changes.
Or am I missing something here?

@SuhilMohammad-rogers
Copy link

Everytime i add a new marker on the MapView, the MapView seems to rerender, it looks like its zooming in and out. i wonder if thats happening because this package is currently using the legacy renderer

@mak12
Copy link

mak12 commented Nov 24, 2021

Any timeline for this implementation ? current implementation isn't accepting playServicesVersion:18.0.0 from project level configurations.

@siddharth-kt
Copy link

any update on this ?

@christopherdro
Copy link
Collaborator

@Borduhh @siddharth-kt @pke @mak12 @dishantwalia Please take a look at this open PR #4055.
It would be very helpful if you can test the proposed changes with your app and report back with any issues you come across.

@monholm
Copy link
Collaborator

monholm commented Mar 25, 2022

The new renderer can be now be enabled starting from v0.31.0-beta.2 which is released on the beta channel of npm. Props to @isidoro98.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests