Adding tileSize props for iOS. #2627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
There are some related open issues talking about tile size. And there is one issue asking for PR of tile size props. So here it is this PR trying to resolve these issue.
What issue is this PR fixing?
Support for tileSize in UrlTile props #2567
How did you test this PR?
On iOS, use the sample code to initialize a map view with URL tile on it. And the tile's size should be other than 256 to trigger the issue that on iOS default tile size (256 * 256) is always used.
Then in your UrlTile component, add a tileSize prop with the expected tile size number and run your app again. Now you should see the tile being correctly rendered according to your tile size prop.