Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .jsx file endings for components #99

Closed
weblogixx opened this issue May 5, 2015 · 3 comments
Closed

Use .jsx file endings for components #99

weblogixx opened this issue May 5, 2015 · 3 comments

Comments

@weblogixx
Copy link
Member

It would be nice if the generator would use the correct file ending for generated components (.jsx instead of .js). This would have the benefit that editors (like Atom or Brackets) would be able to guess the file format correclty if they support jsx-syntax.

@newtriks
Copy link
Member

newtriks commented May 5, 2015

Hey @weblogixx, thanks for the comment. This has been previously discussed #49

@newtriks newtriks closed this as completed May 5, 2015
@weblogixx
Copy link
Member Author

Hi @newtriks,

thank you for your fast response. I think in this case it should at least be optional to use the .jsx (defaulting to .js).

When using CI-Tools (like SonarQube or linters like jsHint) files with jsx-syntax are not parseable and will therefore lead to errors that must be fixed in each of those various systems.

@newtriks newtriks reopened this May 6, 2015
@newtriks
Copy link
Member

newtriks commented May 6, 2015

@weblogixx good point, as an option would be feasible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants