Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull docker version from docker hub #130

Open
brent-hoover opened this issue Oct 17, 2022 · 2 comments
Open

Pull docker version from docker hub #130

brent-hoover opened this issue Oct 17, 2022 · 2 comments
Labels
enhancement New feature or request hacktoberfest Tickets good for hackathon work

Comments

@brent-hoover
Copy link
Collaborator

brent-hoover commented Oct 17, 2022 •
edited
Loading

When you create a new project-api the docker file that is used from the project template has a hardcoded reaction version. It should pull whatever is the the latest version number at the time of project creation from docker hub and use that instead. For deterministic builds we DO NOT want to use :latest
@brent-hoover brent-hoover added enhancement New feature or request hacktoberfest Tickets good for hackathon work labels Oct 17, 2022
@ankiiitraj ankiiitraj mentioned this issue Oct 17, 2022
Closed
@skodamarthi
Copy link

skodamarthi commented Oct 28, 2022 •
edited
Loading

@zenweasel Can I work on this? Do you want it to be pinned to the latest version of reactioncommerce/reaction?

@skodamarthi skodamarthi mentioned this issue Oct 28, 2022
Closed
@rum1887
Copy link

rum1887 commented Oct 7, 2023 •
edited
Loading

@zenweasel is the issue still open? for hacktoberfest 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest Tickets good for hackathon work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

patch: use latest docker image for reaction ankiiitraj/cli
3 participants
@brent-hoover @skodamarthi @rum1887