Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit caching withCart decorator mutation results #193

Closed
mikemurray opened this issue Jul 30, 2018 · 5 comments
Closed

Revisit caching withCart decorator mutation results #193

mikemurray opened this issue Jul 30, 2018 · 5 comments

Comments

@mikemurray
Copy link
Member

Issue

Revisit caching the result of the createCart and addCartItems in the @withCart decorator. Apollo should be updating the cache after these mutations, but it currently isn't.

Solution

  • Research methods to update the cache with Apollo mutations
  • Implement solution and test
@mikemurray mikemurray added this to the Jupiter milestone Jul 30, 2018
@mikemurray mikemurray added the enhancement For issues that describe a feature that needs to be added, changed, or removed, but is not a bug label Jul 30, 2018
@spencern spencern modified the milestones: Jupiter, Kit Carson Aug 7, 2018
@aldeed aldeed modified the milestones: Kit Carson, Little Bear Aug 24, 2018
@spencern spencern modified the milestones: Little Bear, Massive Sep 4, 2018
@spencern
Copy link
Contributor

spencern commented Sep 4, 2018

@mikemurray will you check to see if this should be a release blocker?

@mikemurray
Copy link
Member Author

@spencern This shouldn't be a release blocker as things are working now. If there is time before the release then an attempt may be made to make the necessary updates; otherwise, this can wait until after the release.

@spencern spencern modified the milestones: Massive, North Maroon Sep 18, 2018
@spencern spencern modified the milestones: North Maroon, Oxford Oct 2, 2018
@spencern
Copy link
Contributor

spencern commented Oct 2, 2018

@mikemurray how important is this issue to resolve?

@willopez
Copy link
Member

willopez commented Oct 2, 2018

@mikemurray updating the local cache as seen in the following link, works for me: https://github.com/reactioncommerce/reaction-next-starterkit/blob/develop/src/containers/cart/withCart.js#L78

@spencern
Copy link
Contributor

@mikemurray @willopez can we close this issue?

@spencern spencern removed the enhancement For issues that describe a feature that needs to be added, changed, or removed, but is not a bug label Oct 18, 2018
@spencern spencern removed this from the Oxford milestone Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants