Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript type definitions #479

Open
Kiailandi opened this issue Mar 6, 2020 · 5 comments
Open

TypeScript type definitions #479

Kiailandi opened this issue Mar 6, 2020 · 5 comments

Comments

@Kiailandi
Copy link

Kiailandi commented Mar 6, 2020

Hello,

I might be wrong, but I wasn't able to find any TS definition for @reactioncommerce/components.

Is this a problem on my side or are there no TS definitions to be found?

I really like the Reaction Commerce component library, but having to manually declare a definition for each component is really slowing down my development process.

In case no definition is available would you be interested in adding them? I could probably try to contribute.

Thanks.

@rymorgan
Copy link

rymorgan commented Mar 6, 2020

@mikemurray @willopez Thoughts on this?

@aldeed
Copy link
Contributor

aldeed commented Mar 11, 2020

There aren't any yet but we would welcome any PRs to add some

@HarisSpahija
Copy link

I think there are ways to use the current proptypes in combination with type definitions. Perhaps you could find a tool that converts them?

@Kiailandi
Copy link
Author

I will try to find something and report back.

@ghost
Copy link

ghost commented Mar 10, 2021

See also: reactioncommerce/example-storefront#709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants