Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to react: Alerts, Language and other dropdowns #2044

Closed
rymorgan opened this issue Mar 27, 2017 · 6 comments
Closed

Convert to react: Alerts, Language and other dropdowns #2044

rymorgan opened this issue Mar 27, 2017 · 6 comments
Assignees

Comments

@rymorgan
Copy link
Contributor

rymorgan commented Mar 27, 2017

Convert to react: Alerts, Language and other dropdowns related to #2040

@rymorgan rymorgan added this to the Next milestone Mar 27, 2017
This was referenced Mar 28, 2017
@aaronjudd aaronjudd modified the milestones: Next, React UI Components Apr 25, 2017
@mikemurray mikemurray modified the milestones: React - Navigation Bar, React UI Components May 2, 2017
@aaronjudd aaronjudd removed the backlog label May 2, 2017
@brent-hoover
Copy link
Collaborator

@rymorgan Can you clarify what you mean by Alerts here? Do you mean the notifications?
reaction

@joykare joykare self-assigned this May 4, 2017
@joykare
Copy link
Contributor

joykare commented May 4, 2017

Notes:

  • Branch joykare-navbar-dropdowns-2044
  • @rymorgan hoping that alerts means the notifications. If so its already in React.
  • Starting with the currency dropdown /client/modules/i18n/templates/currency

@joykare
Copy link
Contributor

joykare commented May 5, 2017

Notes:

  • Using DropDownMenu Component on /imports/plugins/core/ui/client/components/menu
  • Working on the language dropdown /client/modules/i18n/templates/header/i18n.html

@joykare
Copy link
Contributor

joykare commented May 11, 2017

@mikemurray I'm using <DropDownMenu /> component for the drop downs and I'm trying to figure out a way to close the menu when one of the menuitems is selected. Any ideas on how to make that happen?

@mikemurray
Copy link
Member

This will require some additions to both DropDownMenu and the Popover component

  1. The Popover manages state for the open / close status. That will need to be exposed to props so it could/should be managed by the parent component. Probably best to remove all the state management from that component and replace with callbacks, and accept the open/close state as props.
  2. The dropdown itself menu should have an open/close state var.
  3. In the handleMenuItemChange callback in the dropdown would set the open/close state and pass that to the popover component via props.

@joykare
Copy link
Contributor

joykare commented May 11, 2017

Thanks that worked @mikemurray

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants