Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catalog migration fails when no position data exists #4299

Closed
brent-hoover opened this issue Jun 5, 2018 · 2 comments · Fixed by #4302
Closed

Catalog migration fails when no position data exists #4299

brent-hoover opened this issue Jun 5, 2018 · 2 comments · Fixed by #4302
Assignees
@aldeed
Labels
bug For issues that describe a defect or regression in the released software
Milestone
Fletcher

Comments

@brent-hoover
Copy link
Collaborator

Issue Description

Migration fails on startup on first start after migration to v1.12.0

Get this error

0|reaction | TypeError: Cannot convert undefined or null to object
0|reaction |     at Function.keys (<anonymous>)
0|reaction |     at items.forEach (imports/plugins/core/versions/server/migrations/25_update_catalog_schema.js:28:12)

Steps to Reproduce

  1. Start Reaction with a previous version and load data
  2. Upgrade to v1.12.0
  3. Observe error on startup. Migrations become locked

Versions

Node: 8.9.4
NPM: 5.6.0
Meteor Node: 8.11.2
Meteor NPM: 5.10.0
Reaction CLI: 0.29.0
@aldeed
Copy link
Contributor

aldeed commented Jun 5, 2018 •
edited
Loading

@spencern We should probably hotfix this in 1.12.1. It fails the migration if you have products that were never manually positioned (or for some reason don't have a positions object on them).

I can push a fix tomorrow.

@spencern
Copy link
Contributor

spencern commented Jun 5, 2018

@aldeed Let's plan on that.

@brent-hoover brent-hoover added bug For issues that describe a defect or regression in the released software impact-critical labels Jun 5, 2018
@aldeed aldeed self-assigned this Jun 5, 2018
@aldeed aldeed added this to the Fletcher milestone Jun 5, 2018
@aldeed aldeed mentioned this issue Jun 5, 2018
Merged
@spencern spencern mentioned this issue Jun 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aldeed aldeed

Labels
bug For issues that describe a defect or regression in the released software
Projects
None yet
Milestone
Fletcher
Development

Successfully merging a pull request may close this issue.

Release 1.12.1 reactioncommerce/reaction
3 participants
@brent-hoover @spencern @aldeed