Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing fields on Product GQL schema and more translation strings needed #6114

Closed
mikemurray opened this issue Feb 27, 2020 · 0 comments · Fixed by #6141
Closed

Missing fields on Product GQL schema and more translation strings needed #6114

mikemurray opened this issue Feb 27, 2020 · 0 comments · Fixed by #6141
Assignees
@mikemurray

Comments

@mikemurray
Copy link
Member

Issue Description

This issue is resolving missing things found when updating the product admin UI to use the GQL API. reactioncommerce/reaction-admin#188

Product schema is missing fields for

  • shouldAppearInSitemap

Need additional translations added to API

  • "Create a variant"
  • "Create a variant option"
  • "Make visible in storefront"
  • "Delete this variant"
  • "Delete this option"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikemurray mikemurray

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Fixes for product editor reactioncommerce/reaction
1 participant
@mikemurray