Merge pull request #17 from courseload/skip-null-props

Skip processing props that are null or undefined
reactjs · Mar 19, 2015 · e7d1373 · e7d1373
2 parents 22bdc2d + 026d596
commit e7d1373
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/__tests__/index-test.js b/lib/__tests__/index-test.js
@@ -35,6 +35,18 @@ describe('props', () => {
         });
       });
 
+      it('does not warn if onClick is null', () => {
+        doNotExpectWarning(assertions.props.onClick.NO_LABEL.msg, () => {
+          <div onClick={null}/>;
+        });
+      });
+
+      it('does not warn if onClick is undefined', () => {
+        doNotExpectWarning(assertions.props.onClick.NO_LABEL.msg, () => {
+          <div onClick={undefined}/>;
+        });
+      });
+
       it('does not warn if there is an aria-label', () => {
         doNotExpectWarning(assertions.props.onClick.NO_LABEL.msg, () => {
           <div aria-label="foo" onClick={k}/>;

diff --git a/lib/index.js b/lib/index.js
@@ -11,6 +11,7 @@ var assertAccessibility = (tagName, props, children, log) => {
 
   var propTests;
   for (var propName in props) {
+    if (props[propName] === null || props[propName] === undefined) continue;
     propTests = assertions.props[propName];
     if (propTests)
       for (key in propTests)
@@ -39,4 +40,3 @@ module.exports = (options) => {
     return _createElement.apply(this, arguments);
   };
 };
-