Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing dep: object.assign #115

Closed
wmertens opened this issue Mar 8, 2016 · 4 comments
Closed

Missing dep: object.assign #115

wmertens opened this issue Mar 8, 2016 · 4 comments

Comments

@wmertens
Copy link

wmertens commented Mar 8, 2016

See #113 - object.assign should be added as a dependency or included in the build.
@vitkon
Copy link

vitkon commented Mar 8, 2016

Module not found: Error: Cannot resolve module 'object.assign' in /node_modules/react-a11y/dist

@vitkon vitkon mentioned this issue Mar 8, 2016
Closed
@ljharb
Copy link

ljharb commented Mar 8, 2016

Thanks for the report - indeed object.assign needs to be moved from devDeps to deps.

wyattdanger added a commit to wyattdanger/react-a11y that referenced this issue Mar 8, 2016
@wyattdanger
[fixed] Move object.assign from devDeps to deps (resolves reactjs#115)
312955d
wyattdanger added a commit to wyattdanger/react-a11y that referenced this issue Mar 8, 2016
@wyattdanger
[fixed] Move object.assign from devDeps to deps (resolves reactjs#115)
30ddfb8
wyattdanger added a commit that referenced this issue Mar 8, 2016
@wyattdanger
Merge pull request #117 from wyattdanger/object-assign-to-deps-bugfix
b4e40ec 
[fixed] Move object.assign from devDeps to deps (resolves #115)
@wyattdanger
Copy link
Collaborator

@wmertens @vitkon 0.3.1 is released

@wmertens
Copy link
Author

wmertens commented Mar 9, 2016

🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ljharb @wmertens @wyattdanger @vitkon