Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with React 0.14: "Cannot assign to read only property 'id' of #<Object>" #79

Closed
EvHaus opened this issue Jul 14, 2015 · 7 comments

Comments

@EvHaus
Copy link

EvHaus commented Jul 14, 2015

I've been migrating to React 0.14 and I'm starting to get this error from react-a11y when instantiating new components via renderSubtreeIntoContainer:

TypeError: Cannot assign to read only property 'id' of #<Object>
    at Object.React.createElement (webpack:///./~/react-a11y/dist/index.js?:171:14)
    at render (eval at executeCode (webpack:///./html/js/libs/ReactPlayground.js?), <anonymous>:23:16)
    at ReactCompositeComponentMixin._renderValidatedComponentWithoutOwnerOrContext (webpack:///./~/react/lib/ReactCompositeComponent.js?:546:34)
    at ReactCompositeComponentMixin._renderValidatedComponent (webpack:///./~/react/lib/ReactCompositeComponent.js?:566:32)
    at ReactPerf.measure.wrapper (webpack:///./~/react/lib/ReactPerf.js?:66:21)
    at ReactCompositeComponentMixin.mountComponent (webpack:///./~/react/lib/ReactCompositeComponent.js?:181:32)
    at ReactPerf.measure.wrapper [as mountComponent] (webpack:///./~/react/lib/ReactPerf.js?:66:21)
    at Object.ReactReconciler.mountComponent (webpack:///./~/react/lib/ReactReconciler.js?:37:35)
    at ReactDOMComponent.ReactMultiChild.Mixin.mountChildren (webpack:///./~/react/lib/ReactMultiChild.js?:187:44)
    at ReactDOMComponent.Mixin._createContentMarkup (webpack:///./~/react/lib/ReactDOMComponent.js?:498:32)

Any ideas what could be going wrong?

@EvHaus EvHaus changed the title "Cannot assign to read only property 'id' of #<Object>" Incompatible with React 0.14: "Cannot assign to read only property 'id' of #<Object>" Sep 10, 2015
@EvHaus
Copy link
Author

EvHaus commented Sep 10, 2015

I believe this is caused by the fact that react-a11y is trying to change component props which is no longer allowed in React 0.14.

@devgeeks
Copy link

👍

@devgeeks
Copy link

devgeeks commented Oct 8, 2015

Bumping for React v0.14.0 being out now. ;)

@codepunkt
Copy link

This has been known since July, React 0.14 is out for more than 2 weeks, there is a pull request #96 fixing this and nothing happened yet?

Y U NO ACCEPT PR?

@romeovs
Copy link
Collaborator

romeovs commented Oct 27, 2015

👍 let's fix this!

@xjamundx
Copy link

I think this fix has been merged and fixed as of v0.2.7

@erin-doyle
Copy link
Collaborator

I don't believe this is an issue any longer. I'm closing this for now but if someone is still having this problem please reply and I'll reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants