-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strip custom prop-types in production #448
Conversation
Minified size with bundled dependencies before 17.53 KB After 16.66 KB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, I'm assuming the direct assignment to .propTypes is because the Babel plugin doesn't strip them otherwise?
Yep |
@jquense Is this good now? |
## [2.5.3](v2.5.2...v2.5.3) (2019-01-14) ### Bug Fixes * strip custom prop-types in production ([#448](#448)) ([46fa20f](46fa20f))
🎉 This PR is included in version 2.5.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
-200 B gzipped https://bundlephobia.com/[email protected] 🚀 |
hmm we are still including the prop-types library tho. seems like the import isn't getting stripped |
@jquense It's not. I wish the babel plugin was doing such. |
It's another gain potential. https://bundlephobia.com/[email protected]. However, I'm not sure how we can make it work with ESM modules. Conditionally importing modules? 🤔. |
It's because of old context api I guess |
…d-compatible * origin/master: chore: bundle UMD with rollup (reactjs#449) chore(release): 2.5.3 [skip ci] fix: strip custom prop-types in production (reactjs#448) chore: fix storybook (reactjs#445) chore(release): 2.5.2 [skip ci] fix: pass appear to CSSTransition callbacks (reactjs#441) docs: Fix type declaration comment (reactjs#439) chore(release): 2.5.1 [skip ci] fix: prevent calling setState in TransitionGroup if it has been unmounted (reactjs#435)
…d-compatible * origin/master: chore: bundle UMD with rollup (reactjs#449) chore(release): 2.5.3 [skip ci] fix: strip custom prop-types in production (reactjs#448) chore: fix storybook (reactjs#445) chore(release): 2.5.2 [skip ci] fix: pass appear to CSSTransition callbacks (reactjs#441) docs: Fix type declaration comment (reactjs#439) chore(release): 2.5.1 [skip ci] fix: prevent calling setState in TransitionGroup if it has been unmounted (reactjs#435)
## [2.5.3](reactjs/react-transition-group@v2.5.2...v2.5.3) (2019-01-14) ### Bug Fixes * strip custom prop-types in production ([#448](reactjs/react-transition-group#448)) ([46fa20f](reactjs/react-transition-group@46fa20f))
## [2.5.3](reactjs/react-transition-group@v2.5.2...v2.5.3) (2019-01-14) ### Bug Fixes * strip custom prop-types in production ([#448](reactjs/react-transition-group#448)) ([46fa20f](reactjs/react-transition-group@46fa20f))
## [2.5.3](reactjs/react-transition-group@v2.5.2...v2.5.3) (2019-01-14) ### Bug Fixes * strip custom prop-types in production ([#448](reactjs/react-transition-group#448)) ([46fa20f](reactjs/react-transition-group@46fa20f))
## [2.5.3](reactjs/react-transition-group@v2.5.2...v2.5.3) (2019-01-14) ### Bug Fixes * strip custom prop-types in production ([#448](reactjs/react-transition-group#448)) ([46fa20f](reactjs/react-transition-group@46fa20f))
Minified size with bundled dependencies before
17.53 KB
After
16.66 KB