breaking: Use stable context API #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate of #427 |
| @@ -50,8 +50,8 @@ | |||
| ] | |||
| }, | |||
| "peerDependencies": { | |||
| "react": ">=15.0.0", | |||
| "react-dom": ">=15.0.0" | |||
| "react": ">=16.6.0", | |||
There was a problem hiding this comment.
We can kill react-lifecycles-compat now, awesome!
https://bundlephobia.com/[email protected]
eps1lon
force-pushed
the
feat/stable-context
branch
from
6b68721 to
f175957
Compare
eps1lon
added a commit
to eps1lon/react-transition-group
that referenced
this pull request
Apr 11, 2019
Cherry-picking reactjs#471
|
Could this be released as @3 or even beta? Current legacy context implementation has issues when used with latest react-router and react-redux both of which are using the new Context API. This pull request fixes those issues I'm seeing in my code |
jquense
approved these changes
Apr 15, 2019
|
we've got semantic release now, let's (talking mostly to myself) not be afraid of bumping integers |
jquense
pushed a commit
that referenced
this pull request
Apr 15, 2019
# [3.0.0](v2.9.0...v3.0.0) (2019-04-15) ### Features * use stable context API ([#471](#471)) ([aee4901](aee4901)), closes [#429](#429) ### BREAKING CHANGES * use new style react context ```diff // package.json -"react": "^15.0.0", +"react": "^16.6.0", -"react-dom": "^15.0.0", +"react-dom": "^16.6.0", ```
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@jquense So fast. I expected esm support to be released in v3 as major change. |
johnfrench3
pushed a commit
to johnfrench3/transition-group-react
that referenced
this pull request
Nov 2, 2022
# [3.0.0](reactjs/react-transition-group@v2.9.0...v3.0.0) (2019-04-15) ### Features * use stable context API ([#471](reactjs/react-transition-group#471)) ([aee4901](reactjs/react-transition-group@aee4901)), closes [#429](reactjs/react-transition-group#429) ### BREAKING CHANGES * use new style react context ```diff // package.json -"react": "^15.0.0", +"react": "^16.6.0", -"react-dom": "^15.0.0", +"react-dom": "^16.6.0", ```
patrickm68
added a commit
to patrickm68/react-transition-group-developer
that referenced
this pull request
Dec 1, 2022
# [3.0.0](reactjs/react-transition-group@v2.9.0...v3.0.0) (2019-04-15) ### Features * use stable context API ([#471](reactjs/react-transition-group#471)) ([aee4901](reactjs/react-transition-group@aee4901)), closes [#429](reactjs/react-transition-group#429) ### BREAKING CHANGES * use new style react context ```diff // package.json -"react": "^15.0.0", +"react": "^16.6.0", -"react-dom": "^15.0.0", +"react-dom": "^16.6.0", ```
shaikdev2
pushed a commit
to shaikdev2/transition-group-react
that referenced
this pull request
Jun 9, 2023
# [3.0.0](reactjs/react-transition-group@v2.9.0...v3.0.0) (2019-04-15) ### Features * use stable context API ([#471](reactjs/react-transition-group#471)) ([aee4901](reactjs/react-transition-group@aee4901)), closes [#429](reactjs/react-transition-group#429) ### BREAKING CHANGES * use new style react context ```diff // package.json -"react": "^15.0.0", +"react": "^16.6.0", -"react-dom": "^15.0.0", +"react-dom": "^16.6.0", ```
GreenCat1996
added a commit
to GreenCat1996/react-transition-group
that referenced
this pull request
Aug 1, 2023
# [3.0.0](reactjs/react-transition-group@v2.9.0...v3.0.0) (2019-04-15) ### Features * use stable context API ([#471](reactjs/react-transition-group#471)) ([aee4901](reactjs/react-transition-group@aee4901)), closes [#429](reactjs/react-transition-group#429) ### BREAKING CHANGES * use new style react context ```diff // package.json -"react": "^15.0.0", +"react": "^16.6.0", -"react-dom": "^15.0.0", +"react-dom": "^16.6.0", ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[email protected]allows usage of staticcontextType. With16.0.0we would need a higher-order component that puts the context value into props sinceTransitionneeds to have access to the context in its constructor.Partial fix for #429
breaking change