Support SSR #619
Merged
Support SSR #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Transition.js
Outdated
| nodeRef: PropTypes.shape({ | ||
| current: typeof Element === 'undefined' | ||
| ? PropTypes.any | ||
| : PropTypes.instanceOf(Element) |
There was a problem hiding this comment.
Could we not rely on "Element" for this prop-type? My concern is equivalent to merceyz/typescript-to-proptypes#3.
There was a problem hiding this comment.
The problem can be noticed on mui/material-ui#21858 (comment).
jquense
pushed a commit
that referenced
this pull request
May 6, 2020
## [4.4.1](v4.4.0...v4.4.1) (2020-05-06) ### Bug Fixes * transition SSR ([#619](#619)) ([2722bb6](2722bb6))
|
🎉 This PR is included in version 4.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 tasks
johnfrench3
pushed a commit
to johnfrench3/transition-group-react
that referenced
this pull request
Nov 2, 2022
## [4.4.1](reactjs/react-transition-group@v4.4.0...v4.4.1) (2020-05-06) ### Bug Fixes * transition SSR ([#619](reactjs/react-transition-group#619)) ([2722bb6](reactjs/react-transition-group@2722bb6))
patrickm68
added a commit
to patrickm68/react-transition-group-developer
that referenced
this pull request
Dec 1, 2022
## [4.4.1](reactjs/react-transition-group@v4.4.0...v4.4.1) (2020-05-06) ### Bug Fixes * transition SSR ([#619](reactjs/react-transition-group#619)) ([2722bb6](reactjs/react-transition-group@2722bb6))
shaikdev2
pushed a commit
to shaikdev2/transition-group-react
that referenced
this pull request
Jun 9, 2023
## [4.4.1](reactjs/react-transition-group@v4.4.0...v4.4.1) (2020-05-06) ### Bug Fixes * transition SSR ([#619](reactjs/react-transition-group#619)) ([2722bb6](reactjs/react-transition-group@2722bb6))
GreenCat1996
added a commit
to GreenCat1996/react-transition-group
that referenced
this pull request
Aug 1, 2023
## [4.4.1](reactjs/react-transition-group@v4.4.0...v4.4.1) (2020-05-06) ### Bug Fixes * transition SSR ([#619](reactjs/react-transition-group#619)) ([2722bb6](reactjs/react-transition-group@2722bb6))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #618 and adds regression tests to make sure the lib loads in node environment