From f13e1f7cc2fd4517fe47cee2861dac936ae1ac6a Mon Sep 17 00:00:00 2001 From: Marco Silva Date: Tue, 4 Jun 2019 14:13:48 +0100 Subject: [PATCH 1/2] adds missing dependency @babel/runtime Using yarn with pnp enabled enforces a correct dependency structure. While using any module that has this package as a dependency I get the following error: ``` ERROR in /home/msilva/.cache/yarn/v4/npm-react-transition-group-4.1.0-7b50c0a93a6c127336187252c3c1a70eff3304ce/node_modules/react-transition-group/esm/CSSTransition.js Module not found: Error: Package "react-transition-group@4.1.0" (via "/home/msilva/.cache/yarn/v4/npm-react-transition-group-4.1.0-7b50c0a93a6c127336187252c3c1a70eff3304ce/node_modules/react-transition-group/esm/CSSTransition.js") is trying to require the package "@babel/runtime" (via "@babel/runtime/helpers/esm/extends") without it being listed in its dependencies (react, react-dom, dom-helpers, loose-envify, prop-types, react-transition-group) @ /home/msilva/.cache/yarn/v4/npm-react-transition-group-4.1.0-7b50c0a93a6c127336187252c3c1a70eff3304ce/node_modules/react-transition-group/esm/CSSTransition.js 1:0-58 228:43-51 @ /home/msilva/.cache/yarn/v4/npm-react-transition-group-4.1.0-7b50c0a93a6c127336187252c3c1a70eff3304ce/node_modules/react-transition-group/esm/index.js @ /home/msilva/.cache/yarn/v4/npm-@material-ui-core-4.0.2-c7a07c1d1b13b94adf479d7267b51cb682fcb279/node_modules/@material-ui/core/Slide/Slide.js ``` to fix this I added the latest version of @babel/runtime to the dependencies. --- package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/package.json b/package.json index 963d5645..aa0eb210 100644 --- a/package.json +++ b/package.json @@ -58,6 +58,7 @@ "react-dom": ">=16.6.0" }, "dependencies": { + "@babel/runtime": "^7.4.5" "dom-helpers": "^3.4.0", "loose-envify": "^1.4.0", "prop-types": "^15.6.2" From 85ea462b1738f1441e6101354bf688dbcebaf7e2 Mon Sep 17 00:00:00 2001 From: Marco Silva Date: Tue, 4 Jun 2019 14:16:04 +0100 Subject: [PATCH 2/2] fix typo --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index aa0eb210..ddd13cb6 100644 --- a/package.json +++ b/package.json @@ -58,7 +58,7 @@ "react-dom": ">=16.6.0" }, "dependencies": { - "@babel/runtime": "^7.4.5" + "@babel/runtime": "^7.4.5", "dom-helpers": "^3.4.0", "loose-envify": "^1.4.0", "prop-types": "^15.6.2"