Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise UriEndpointFactory/UriEndpoint #829

Open
violetagg opened this issue Aug 31, 2019 · 2 comments · May be fixed by #2700
Open

Revise UriEndpointFactory/UriEndpoint #829

violetagg opened this issue Aug 31, 2019 · 2 comments · May be fixed by #2700
Labels
type/enhancement A general enhancement
Milestone
1.2.x Backlog

Comments

@violetagg
Copy link
Member

No description provided.

@violetagg violetagg added the type/enhancement A general enhancement label Aug 31, 2019
@violetagg violetagg added this to the General Backlog milestone Aug 31, 2019
@yuzawa-san yuzawa-san mentioned this issue Feb 10, 2023
Closed
@yuzawa-san
Copy link
Contributor

I sent off this spring-projects/spring-framework#29954

I'm willing submit a patch to this repo to ideally have the provided URI not have to be reparsed later to generate path and resourcePath. I think I can accomplish this by putting URI inside of the UriEndpoint class. Is that an acceptable solution? A lot of the classes are not public, so think I could do it with no API changes.

@violetagg
Copy link
Member Author

@yuzawa-san Please provide a PR so that we can discuss the changes. Thanks!

yuzawa-san added a commit to yuzawa-san/reactor-netty that referenced this issue Feb 20, 2023
@yuzawa-san
Refactor UriEndpoint (reactor#829)
70bd5ab 
Clean up UriEndpoint logic to be based around the java.net.URI. Move relevant methods into this class. Construct instances using static method. Only calculate derived values on demand (e.g. toExternalForm) when needed in the various request implementations. Cleaned up redirection logic. Added additional tests.

Fixes reactor#829
@yuzawa-san yuzawa-san linked a pull request Feb 20, 2023 that will close this issue
Open
yuzawa-san added a commit to yuzawa-san/reactor-netty that referenced this issue Feb 20, 2023
@yuzawa-san
Refactor UriEndpoint (reactor#2700)
2c6249f 
Clean up UriEndpoint logic to be based around the java.net.URI. Move relevant methods into this class. Construct instances using static method. Only calculate derived values on demand (e.g. toExternalForm) when needed in the various request implementations. Cleaned up redirection logic. Added additional tests. Made conversion from InetSocketAddress more efficient (removed the substrings which trimmed out the ports). Fixed HttpClientTest to support ipv6 (by using NetUtil.toSocketAddressString to get the [] around the address, and also fixed FailedHttpClientRequest.uri() from returning full URI rather than just Netty definition of "uri" which is raw path and query. Fixed ClientTransportTest to support ipv6.

Fixes reactor#829
yuzawa-san added a commit to yuzawa-san/reactor-netty that referenced this issue Feb 20, 2023
@yuzawa-san
Refactor UriEndpoint (reactor#2700)
22b04c2 
Clean up UriEndpoint logic to be based around the java.net.URI. Move relevant methods into this class. Construct instances using static method. Only calculate derived values on demand (e.g. toExternalForm) when needed in the various request implementations. Cleaned up redirection logic. Added additional tests. Made conversion from InetSocketAddress more efficient (removed the substrings which trimmed out the ports). Fixed HttpClientTest to support ipv6 (by using NetUtil.toSocketAddressString to get the [] around the address, and also fixed FailedHttpClientRequest.uri() from returning full URI rather than just Netty definition of "uri" which is raw path and query. Fixed ClientTransportTest to support ipv6.

Fixes reactor#829
yuzawa-san added a commit to yuzawa-san/reactor-netty that referenced this issue Feb 21, 2023
@yuzawa-san
Refactor UriEndpoint (reactor#2700)
fa0a47f 
Clean up UriEndpoint logic to be based around the java.net.URI. Move relevant methods into this class. Construct instances using static method. Only calculate derived values on demand (e.g. toExternalForm) when needed in the various request implementations. Cleaned up redirection logic. Added additional tests. Made conversion from InetSocketAddress more efficient (removed the substrings which trimmed out the ports). Fixed HttpClientTest to support ipv6 (by using NetUtil.toSocketAddressString to get the [] around the address, and also fixed FailedHttpClientRequest.uri() from returning full URI rather than just Netty definition of "uri" which is raw path and query. Fixed ClientTransportTest to support ipv6.

Fixes reactor#829
yuzawa-san added a commit to yuzawa-san/reactor-netty that referenced this issue Mar 3, 2023
@yuzawa-san
Refactor UriEndpoint (reactor#2700)
fa714ad 
Clean up UriEndpoint logic to be based around the java.net.URI. Move relevant methods into this class. Construct instances using static method. Only calculate derived values on demand (e.g. toExternalForm) when needed in the various request implementations. Cleaned up redirection logic. Added additional tests. Made conversion from InetSocketAddress more efficient (removed the substrings which trimmed out the ports). Fixed HttpClientTest to support ipv6 (by using NetUtil.toSocketAddressString to get the [] around the address, and also fixed FailedHttpClientRequest.uri() from returning full URI rather than just Netty definition of "uri" which is raw path and query. Fixed ClientTransportTest to support ipv6.

Fixes reactor#829
yuzawa-san added a commit to yuzawa-san/reactor-netty that referenced this issue Mar 15, 2023
@yuzawa-san
Refactor UriEndpoint (reactor#2700)
02f9ae6 
Clean up UriEndpoint logic to be based around the java.net.URI. Move relevant methods into this class. Construct instances using static method. Only calculate derived values on demand (e.g. toExternalForm) when needed in the various request implementations. Cleaned up redirection logic. Added additional tests. Made conversion from InetSocketAddress more efficient (removed the substrings which trimmed out the ports). Fixed HttpClientTest to support ipv6 (by using NetUtil.toSocketAddressString to get the [] around the address, and also fixed FailedHttpClientRequest.uri() from returning full URI rather than just Netty definition of "uri" which is raw path and query. Fixed ClientTransportTest to support ipv6.

Fixes reactor#829
yuzawa-san added a commit to yuzawa-san/reactor-netty that referenced this issue Mar 19, 2023
@yuzawa-san
Refactor UriEndpoint (reactor#2700)
e241f5f 
Clean up UriEndpoint logic to be based around the java.net.URI. Move relevant methods into this class. Construct instances using static method. Only calculate derived values on demand (e.g. toExternalForm) when needed in the various request implementations. Cleaned up redirection logic. Added additional tests. Made conversion from InetSocketAddress more efficient (removed the substrings which trimmed out the ports). Fixed HttpClientTest to support ipv6 (by using NetUtil.toSocketAddressString to get the [] around the address, and also fixed FailedHttpClientRequest.uri() from returning full URI rather than just Netty definition of "uri" which is raw path and query. Fixed ClientTransportTest to support ipv6.

Fixes reactor#829
yuzawa-san added a commit to yuzawa-san/reactor-netty that referenced this issue Mar 30, 2023
@yuzawa-san
Refactor UriEndpoint (reactor#2700)
7531e2f 
Clean up UriEndpoint logic to be based around the java.net.URI. Move relevant methods into this class. Construct instances using static method. Only calculate derived values on demand (e.g. toExternalForm) when needed in the various request implementations. Cleaned up redirection logic. Added additional tests. Made conversion from InetSocketAddress more efficient (removed the substrings which trimmed out the ports). Fixed HttpClientTest to support ipv6 (by using NetUtil.toSocketAddressString to get the [] around the address, and also fixed FailedHttpClientRequest.uri() from returning full URI rather than just Netty definition of "uri" which is raw path and query. Fixed ClientTransportTest to support ipv6.

Fixes reactor#829
yuzawa-san added a commit to yuzawa-san/reactor-netty that referenced this issue Apr 4, 2023
@yuzawa-san
Refactor UriEndpoint (reactor#2700)
df1387f 
Clean up UriEndpoint logic to be based around the java.net.URI. Move relevant methods into this class. Construct instances using static method. Only calculate derived values on demand (e.g. toExternalForm) when needed in the various request implementations. Cleaned up redirection logic. Added additional tests. Made conversion from InetSocketAddress more efficient (removed the substrings which trimmed out the ports). Fixed HttpClientTest to support ipv6 (by using NetUtil.toSocketAddressString to get the [] around the address, and also fixed FailedHttpClientRequest.uri() from returning full URI rather than just Netty definition of "uri" which is raw path and query. Fixed ClientTransportTest to support ipv6.

Fixes reactor#829
yuzawa-san added a commit to yuzawa-san/reactor-netty that referenced this issue Apr 18, 2023
@yuzawa-san
Refactor UriEndpoint (reactor#2700)
1dbefb7 
Clean up UriEndpoint logic to be based around the java.net.URI. Move relevant methods into this class. Construct instances using static method. Only calculate derived values on demand (e.g. toExternalForm) when needed in the various request implementations. Cleaned up redirection logic. Added additional tests. Made conversion from InetSocketAddress more efficient (removed the substrings which trimmed out the ports). Fixed HttpClientTest to support ipv6 (by using NetUtil.toSocketAddressString to get the [] around the address, and also fixed FailedHttpClientRequest.uri() from returning full URI rather than just Netty definition of "uri" which is raw path and query. Fixed ClientTransportTest to support ipv6.

Fixes reactor#829
yuzawa-san added a commit to yuzawa-san/reactor-netty that referenced this issue May 16, 2023
@yuzawa-san
Refactor UriEndpoint (reactor#2700)
00f28cc 
Clean up UriEndpoint logic to be based around the java.net.URI. Move relevant methods into this class. Construct instances using static method. Only calculate derived values on demand (e.g. toExternalForm) when needed in the various request implementations. Cleaned up redirection logic. Added additional tests. Made conversion from InetSocketAddress more efficient (removed the substrings which trimmed out the ports). Fixed HttpClientTest to support ipv6 (by using NetUtil.toSocketAddressString to get the [] around the address, and also fixed FailedHttpClientRequest.uri() from returning full URI rather than just Netty definition of "uri" which is raw path and query. Fixed ClientTransportTest to support ipv6.

Fixes reactor#829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
1.2.x Backlog
Development

Successfully merging a pull request may close this issue.

Refactor UriEndpoint yuzawa-san/reactor-netty
2 participants
@violetagg @yuzawa-san