Should we release 0.72.2?

[kelset]

Released, please refer to #82

---

Current Release: 0.72.1

Conversations on this thread are limited:

• major release issues.
• qualified cherry-pick requests of commits on main that did not make the previous patch version.

Please include a link to the specific commit on main to be cherry-picked, for example: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on main, then your request likely belongs as a new issue.
If the issue is a major release issues, please reference the issue here.

---

List of issues we're aware of

• 0.72: Remote debugging broken on Android facebook/react-native#38006
• TextView on production nuking app with OverlappingFileLockException facebook/react-native#37871
• RN 0.72 - Text component dynamic color style issue facebook/react-native#37944

Ordered list of picks (and pick status)

1. Do not create RuntimeExecutor on non-JSI executors (#38125) facebook/react-native#38142 ✅
2. facebook/react-native@c05d822 ✅
3. facebook/react-native@3e30326 ✅
4. facebook/react-native@29f2602 ✅
5. facebook/react-native@a4a0655 🟡✅
6. facebook/react-native@5bda54c ✅
7. facebook/react-native@0c9c57a ✅
8. facebook/react-native@41477c8 ✅
9. facebook/react-native@58adc5e ✅
10. facebook/react-native@86b5b4c ✅
11. facebook/react-native@28f4eba ✅
12. facebook/react-native@0ccbd65 ✅
13. facebook/react-native@8d2eec3 ✅
14. facebook/react-native@eaafc26 ✅

Not merged at the time of picking

1. Set size of Modal only once on Android facebook/react-native#35803

Local commits to backport to main

1. facebook/react-native@8ce471e (from 72.1)

[kelset]

thanks, fixed

[adrianha]

hi, can we cherry pick facebook/react-native@3e30326? 🙏

[kelset]

on it - it's my bad, because of how the script works it picked up a local change I had and added to the other changes

[cipolleschi]

I'll try to give this a shot today.

Do you happen to have the error that is reported? (BTW, we didn't bump hermes, there were no changes in it between 0.72.0 and 0.72.1, so even using the old version would not be a problem! 😉 )

[efstathiosntonas]

I get no error, it just won't install when I run pod install after upgrading react native. It gets synced with rn version only on pod update.

edit: what will happen if hermes is bumped and pod install fails to install / align with rn? This could confuse devs since they expect to be aligned. Ofcourse we should check the pod install output but it might slip.

[cipolleschi]

Ah, that's expected, then.
Looking here, hermes is automatically updated when the tag changes. As I said, we didn't bump Hermes as there were no changes there, so the tag didn't change. And Cocoapods was smart enough to reuse the same version you already had, as it is actually the same! ;)

[efstathiosntonas]

copy! thanks for the heads up @cipolleschi

[efstathiosntonas]

Can we pick this one:

• Fix onChangeText not firing when clearing the value of TextInput with multiline=true on iOS facebook/react-native#37958

it fixes this: facebook/react-native#36930 (comment) and probably this: facebook/react-native#37991

[sammy-SC]

Can we pick:

• facebook/react-native@5bda54c

It disables one optimisation in Fabric which isn't critical but introduced a bug.

[lunaleaps]

Merge facebook/react-native#38142
to fix Android regression of remote debugging mentioned in facebook/react-native#38006

Note: this does not fix iOS remote debugging, still looking into that

[mikehardy]

react-native-firebase still uses remote debugging as it's primary conduit for e2e testing - we have a huge test library that we haven't migrated to another style yet.

So I really, personally, appreciate this one. Huge thanks to @javache for the fix and @lunaleaps for carrying it over!

[lunaleaps]

We should also pick: facebook/react-native@41477c8 for facebook/react-native#38204

[louiszawadzki]

Hi!
Can we cherry pick this fix: facebook/react-native#38121? (commit: facebook/react-native@a4a0655)
It enables turbo modules with Swift code to work on 0.72 with the new architecture.

[cortinico]

I would like to have included this commit:

• facebook/react-native@86b5b4c

Inside .2 as I believe this could mitigate this issue:

• Very long re-rendering times in 0.71.3 facebook/react-native#36296

If that is confirmed as the proper fix, we can backport it to previous versions as well

[Kudo]

also this to fix the hermes inspector on android please: facebook/react-native@41477c8

[efstathiosntonas]

@cortinico this needs to be built from source or we can patch it and test it?

[cortinico]

It needs to be built from source as it's part of the Hermes engine build logic

[cipolleschi]

We forgot to pick this:

• facebook/react-native@c05d822

Which is already in 0.70 and 0.71

[Kudo]

please help to pick this commit for the @react-native/metro-config: facebook/react-native@0ccbd65

[cipolleschi]

Please, don't ask ETAs in this discussion.
The release crew will release a new patch when there are enough commit and the chunk of work required to fix identified bugs is done.
Thank you so much!

[Titozzz]

Hello we probably want to cherry this one: facebook/react-native@28f4eba

[cipolleschi]

Forgot to mention this:

• facebook/react-native@8d2eec3

It landed on Friday!

[oblador]

I'm nominating this metro fix that solves a regression in type: module project:

• facebook/metro@6922933

Not sure of how the release flow works for metro, but I'm guessing the fix needs to be back ported to the 0.76 branch and released as a patch. cc @huntie

[kelset]

we're literally releasing 0.72.2 right now, but let's try to get it into the next patch 😅

[oblador]

OK! I think it might be enough to just do the metro patch release actually 👍