Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: scale modal based on --readthedocs-search-font-size #292

Open
humitos opened this issue Apr 17, 2024 · 0 comments
Open

Search: scale modal based on --readthedocs-search-font-size #292

humitos opened this issue Apr 17, 2024 · 0 comments
Assignees
@zanderle
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@humitos
Copy link
Member

humitos commented Apr 17, 2024

I tried doing the same for search as well, but focused mostly on colors. Making the full design rely on font-size is a bit more tricky for the search modal, because there's more involved than the "simple box" that are the notifications. We can always improve as we move further.

(from #282)
@humitos humitos added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Apr 17, 2024
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Apr 17, 2024
@humitos humitos mentioned this issue Apr 17, 2024
Merged
@zanderle zanderle mentioned this issue Aug 2, 2024
Merged
humitos pushed a commit that referenced this issue Oct 29, 2024
@zanderle
Fix the filters title covering other labels (#354)
6c86cb0 
Fix #293 

There's still a slight difference. The only way to avoid that
completely, would be to remove the default checkbox, and style our own.
But I'm not really keen on that solution.

BTW this styling/positioning will probably be further improved in #292 ,
so this is just a quick solution to make it look better.
@mhilbrunner mhilbrunner mentioned this issue Nov 4, 2024
Open
This was referenced Nov 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanderle zanderle

Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
✨ Addons
Status: No status
📍Roadmap
Status: Planned
Milestone
No milestone
Development

No branches or pull requests
2 participants
@humitos @zanderle